[dpdk-dev] [PATCH 2/2] examples/pipeline: fix incorrect array out of bounds check

Cristian Dumitrescu cristian.dumitrescu at intel.com
Mon Jul 12 20:18:33 CEST 2021


Fix the incorrect array out of bounds check within the function
pipeline_selector_group_member_read().

Coverity issue: 371911
Fixes: 598fe0dd0d8e3 ("examples/pipeline: support selector table")

Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
---
 examples/pipeline/cli.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c
index f67783c8fa..a29be05ef4 100644
--- a/examples/pipeline/cli.c
+++ b/examples/pipeline/cli.c
@@ -1511,7 +1511,7 @@ pipeline_selector_group_member_read(const char *string,
 		if (!token || token_is_comment(token))
 			break;
 
-		if (n_tokens > GROUP_MEMBER_INFO_TOKENS_MAX)
+		if (n_tokens >= GROUP_MEMBER_INFO_TOKENS_MAX)
 			goto error;
 
 		token_array[n_tokens] = token;
-- 
2.17.1



More information about the dev mailing list