[dpdk-dev] [PATCH 2/3] mbuf: avoid cast-align warning in pktmbuf mtod offset macro
Thomas Monjalon
thomas at monjalon.net
Tue Jul 13 09:43:57 CEST 2021
+Cc mbuf maintainers
Please use --cc-cmd devtools/get-maintainer.sh to make it automatic.
13/07/2021 08:49, Eli Britstein:
> In rte_pktmbuf_mtod_offset macro, there is a casting from char * to type
> 't', which may cause cast-align warning when using gcc flags
> '-Werror -Wcast-align':
>
> .../include/rte_mbuf_core.h:723:3: error: cast increases required alignment
> of target type [-Werror=cast-align]
> 723 | ((t)((char *)(m)->buf_addr + (m)->data_off + (o)))
> | ^
>
> As the code assumes correct alignment, add first a (void *) casting, to
> avoid the warning.
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable at dpdk.org
>
> Signed-off-by: Eli Britstein <elibr at nvidia.com>
> ---
> lib/mbuf/rte_mbuf_core.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
> index bb38d7f581..dabdeee604 100644
> --- a/lib/mbuf/rte_mbuf_core.h
> +++ b/lib/mbuf/rte_mbuf_core.h
> @@ -720,7 +720,7 @@ struct rte_mbuf_ext_shared_info {
> * The type to cast the result into.
> */
> #define rte_pktmbuf_mtod_offset(m, t, o) \
> - ((t)((char *)(m)->buf_addr + (m)->data_off + (o)))
> + ((t)(void *)((char *)(m)->buf_addr + (m)->data_off + (o)))
>
> /**
> * A macro that points to the start of the data in the mbuf.
>
More information about the dev
mailing list