[dpdk-dev] [PATCH v5 1/4] examples/vhost: refactor vhost enqueue and dequeue datapaths.

Maxime Coquelin maxime.coquelin at redhat.com
Tue Jul 13 15:34:53 CEST 2021


Hi Wenwu,

Please do not add dot in the commit title.

On 7/5/21 8:11 PM, Wenwu Ma wrote:
> Previously, by judging the flag, we call different enqueue/dequeue
> functions in data path.
> 
> Now, we use an ops that was initialized when Vhost was created,
> so that we can call ops directly in Vhost data path without any more
> flag judgment.
> 
> Signed-off-by: Wenwu Ma <wenwux.ma at intel.com>
> ---
>  examples/vhost/main.c       | 112 ++++++++++++++++++++----------------
>  examples/vhost/main.h       |  33 +++++++++--
>  examples/vhost/virtio_net.c |  16 +++++-
>  3 files changed, 105 insertions(+), 56 deletions(-)
> 

Other than that, it looks good to me.
The typo in the title can be fixed while applying:

Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>

Thanks,
Maxime



More information about the dev mailing list