[dpdk-dev] [PATCH] doc: announce renaming of mbuf offload flags

Andrew Rybchenko andrew.rybchenko at oktetlabs.ru
Sat Jul 31 14:15:50 CEST 2021


On 7/30/21 6:57 PM, Olivier Matz wrote:
> The mbuf offload flags do not match the DPDK namespace (they are
> not prefixed by RTE_). Announce their rename in 21.11, and the
> removal of the old names in 22.11.
> 
> A draft coccinelle script is provided to anticipate what the
> renaming will be.
> 
> Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>

[snip]

> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 9584d6bfd7..04cb141de7 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -147,3 +147,8 @@ Deprecation Notices
>   * cmdline: ``cmdline`` structure will be made opaque to hide platform-specific
>     content. On Linux and FreeBSD, supported prior to DPDK 20.11,
>     original structure will be kept until DPDK 21.11.
> +
> +* mbuf: The mbuf offload flags ``PKT_*`` will be renamed as ``RTE_MBUF_F_*``.
> +  A compatibility layer will be kept until DPDK 22.11, except for the flags
> +  that are already deprecated (ex: ``PKT_RX_L4_CKSUM_BAD``), which will
> +  be removed.
> 

I think it is better to be explicit with defines to be removed:
PKT_RX_L4_CKSUM_BAD, PKT_RX_IP_CKSUM_BAD, PKT_TX_QINQ_PKT,
PKT_RX_EIP_CKSUM_BAD.


More information about the dev mailing list