[dpdk-dev] [PATCH v2 01/62] common/cnxk: add support to lock NIX RQ contexts

Jerin Jacob jerinjacobk at gmail.com
Tue Jun 8 05:47:08 CEST 2021


On Mon, Jun 7, 2021 at 11:55 PM Stephen Hemminger
<stephen at networkplumber.org> wrote:
>
> On Mon, 7 Jun 2021 23:28:42 +0530
> Nithin Dabilpuram <ndabilpuram at marvell.com> wrote:
>
> > From: Satha Rao <skoteshwar at marvell.com>
> >
> > This patch will consider device argument to lock rss table
> > in NIX.
> >
> > This patch also adds few misc fixes such as disabling NIX Tx
> > vlan insertion conf in SMQ, enabling SSO in NIX Tx SQ
> > for Tx completions and TM related stats API.
> >
> > Signed-off-by: Satha Rao <skoteshwar at marvell.com>
>
> In general, breaking patches into smaller parts is helpful.
> But in this case breaking a driver into 62 smaller pieces is getting
> ridiculous. It is too tedious to review the small chunks.

I think, it is other way around. More logically splited patches are
easy to review.

>


More information about the dev mailing list