[dpdk-dev] [PATCH v2 02/62] common/cnxk: update Rx inline IPsec mbox message format

[Nithin Dabilpuram]

On Tue, Jun 08, 2021 at 03:26:08PM +0300, Andrew Rybchenko wrote:
> On 6/7/21 8:58 PM, Nithin Dabilpuram wrote:
> > From: Srujana Challa <schalla at marvell.com>
> > 
> > Updates Rx inline IPSEC mailbox message format to make it
> > sync with latest CPT PF driver.
> > 
> > Signed-off-by: Srujana Challa <schalla at marvell.com>
> > ---
> >  drivers/common/cnxk/roc_mbox.h | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h
> > index f6b11b6..fe4df21 100644
> > --- a/drivers/common/cnxk/roc_mbox.h
> > +++ b/drivers/common/cnxk/roc_mbox.h
> > @@ -1328,6 +1328,9 @@ struct cpt_rxc_time_cfg_req {
> >  struct cpt_rx_inline_lf_cfg_msg {
> >  	struct mbox_msghdr hdr;
> >  	uint16_t __io sso_pf_func;
> > +	uint16_t __io param1;
> > +	uint16_t __io param2;
> > +	uint16_t __io reserved;
> >  };
> >  
> >  enum cpt_eng_type {
> > 
> 
> Isn't is a dead code?
> May be it should be added when it is actually used?

This patch is just a sync of this data structure b/w Kernel and Userspace 
used for mbox communication.
It is already used to generate mbox message request response API's via
and drivers/common/cnxk/roc_mbox_priv.h:158 for all mbox messages.

Since it is common code and just a datastructure update to be in sync
with kernel, isn't it fine ?