[dpdk-dev] [PATCH v3] net/bonding: fix LACP system address check

Ferruh Yigit ferruh.yigit at intel.com
Tue Mar 2 13:10:41 CET 2021


On 2/17/2021 4:30 PM, Ferruh Yigit wrote:
> On 2/17/2021 4:26 PM, Ferruh Yigit wrote:
>> From: Vadim Podovinnikov <podovinnikov at protei.ru>
>>
>> In bond (LACP) we have several NICs (ports), when we have negotiation
>> with peer about what port we prefer, we send information about what
>> system we preferred in partner system name field. Peer also sends us
>> what partner system name it prefer.
>>
>> When we receive a message from it we must compare its preferred system
>> name with our system name, but not with our port mac address
>>
>> In my test I have several problems with that:
>> 1. If master port (mac address same as system address) shuts down (I
>>     have two ports) I loose connection
>> 2. If secondary port (mac address not same as system address) receives
>>     message before master port, my connection is not established.
>>
>> Fixes: 56cbc0817399 ("net/bonding: fix LACP negotiation")
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Vadim Podovinnikov <podovinnikov at protei.ru>
>> ---
>> Cc: zhangliang at bigo.sg
>> Cc: Declan Doherty <declan.doherty at intel.com>
>>
>> v3: Re-sent with rebase
>> * Patch title updated, commit log updated with info shared in email
>> * Sign-off updated with full name
>> * Debug log slightly updated
>> * Syntax slightly updated
> 
> This patch is waiting for review for a long time, if there is no objection I am 
> planning to get it early in the release to give it a time to fix any possible 
> issues.

Chas, Connor, any comment?


More information about the dev mailing list