[dpdk-dev] [EXT] Re: [PATCH 7/7] eventdev: fix ABI breakage due to event vector

Pavan Nikhilesh Bhagavatula pbhagavatula at marvell.com
Tue Mar 16 06:54:38 CET 2021


>On Mon, Mar 8, 2021 at 7:44 PM Jerin Jacob <jerinjacobk at gmail.com>
>wrote:
>> Summary:
>> 1)  Ideal way of adding this feature is to add elements in the
>> existing structure as mentioned
>> in  ("eventdev: introduce event vector Rx capability") in this series.
>> 2) Since this breaking ABI, Introducing a new structure to fix this. I
>> think, we can remove this
>> limitation in 21.11 as that time we can change ABI as required.
>>
>> So, Is this patch needs to be squashed to  ("eventdev: introduce event
>> vector Rx capability") to avoid
>> ABI compatibility between patches? Or Is it OK to break the ABI
>> compatibility in a patch in the series
>> and later fix it in the same series?(This is for more readability as
>> we can revert this patch in 21.11).
>
>What matters is not to break compilation between patches, so that
>bisecting is always possible.
>For ABI checks... I don't see the need to enforce such a requirement.
>
>
>Yet, it is more straightforward to not break the 20.11 ABI at all.
>You can announce the intended ABI change in the release notes /
>deprecation notices, not sure I saw it in this series.
>
>If you still want to share the final state intended for v21.11, you
>can send the patch at the end of the series with something in the
>title like "for v21.11" and mark it deferred in patchwork.
>

Ack, I will rework the series without breaking the ABI till the last patch.

Pavan.

>
>--
>David Marchand



More information about the dev mailing list