[dpdk-dev] [PATCH v4 0/4] eal/windows: do not expose POSIX symbols
Ranjit Menon
ranjit.menon at intel.com
Wed Mar 17 20:23:40 CET 2021
On 3/5/2021 4:04 PM, Dmitry Kozlyuk wrote:
> On Windows, rte_os.h contains a small POSIX compatibility set of
> functions and macros. Exposing it from EAL can break consumer own POSIX
> compatibility layer and is against standards in general.
> Hide these symbols from external consumers, while keeping them available
> for DPDK code.
>
> v4:
> * Instead of creating wrappers and replacing POSIX names in lib/ and
> drivers/, provide POSIX names only to internal consumers.
> * Move renaming from librte_cmdline to librte_eal.
>
> Dmitry Kozlyuk (4):
> eal: add sleep API
> eal: add asprintf() internal wrapper
> build: indicate usage at build time for public headers
> eal/windows: do not expose POSIX symbols
>
> config/meson.build | 3 +
> doc/guides/rel_notes/release_21_05.rst | 3 +
> lib/librte_cmdline/cmdline.c | 4 -
> lib/librte_cmdline/cmdline_socket.c | 4 -
> lib/librte_eal/common/eal_common_errno.c | 4 +
> lib/librte_eal/common/eal_common_lcore.c | 2 +-
> lib/librte_eal/common/eal_common_options.c | 10 +-
> lib/librte_eal/common/eal_common_timer.c | 5 +-
> lib/librte_eal/common/eal_common_trace.c | 2 +-
> lib/librte_eal/common/eal_common_trace_ctf.c | 2 +-
> .../common/eal_common_trace_utils.c | 2 +-
> lib/librte_eal/common/eal_private.h | 18 +++
> lib/librte_eal/include/rte_thread.h | 11 ++
> lib/librte_eal/rte_eal_exports.def | 2 +
> lib/librte_eal/unix/rte_thread.c | 10 +-
> lib/librte_eal/version.map | 3 +
> lib/librte_eal/windows/eal.c | 30 +++++
> lib/librte_eal/windows/eal_thread.c | 9 +-
> lib/librte_eal/windows/include/rte_os.h | 103 ++++--------------
> 19 files changed, 122 insertions(+), 105 deletions(-)
>
Sorry, ack-ed the v1 of this patch series by mistake. This is the real ACK!
Acked-by: Ranjit Menon <ranjit.menon at intel.com>
More information about the dev
mailing list