[dpdk-dev] [PATCH v4 11/11] app/testpmd: fix usage text

[Bing Zhao]

Hi Thomas,

> -----Original Message-----
> From: Jens Freimann <jfreimann at redhat.com>
> Sent: Monday, March 22, 2021 4:27 PM
> To: NBU-Contact-Thomas Monjalon <thomas at monjalon.net>
> Cc: dev at dpdk.org; david.marchand at redhat.com; stable at dpdk.org; Ajit
> Khaparde <ajit.khaparde at broadcom.com>; Bruce Richardson
> <bruce.richardson at intel.com>; Andrew Rybchenko
> <andrew.rybchenko at oktetlabs.ru>; Xiaoyun Li <xiaoyun.li at intel.com>;
> Ori Kam <orika at nvidia.com>; Bing Zhao <bingz at nvidia.com>; Bernard
> Iremonger <bernard.iremonger at intel.com>; Kevin Traynor
> <ktraynor at redhat.com>; Stephen Hemminger
> <stephen at networkplumber.org>; Maciej Czekaj
> <maciej.czekaj at caviumnetworks.com>; Pablo de Lara
> <pablo.de.lara.guarch at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4 11/11] app/testpmd: fix usage text
> 
> External email: Use caution opening links or attachments
> 
> 
> On Sun, Mar 21, 2021 at 11:31:15PM +0100, Thomas Monjalon wrote:
> >The options help text was including an incomplete and redundant
> summary
> >of the options before explaining each. The summary is dropped.
> >
> >The details of the option --hairpin-mode had an extra space,
> breaking
> >the alignment with the next line.
> >
> >There were some mismatches between options in the usage text
> >       sed -rn 's/.*\(" *--([a-z-]*)[=: ].*/\1/p'
> >app/test-pmd/parameters.c and the options declared in lgopts array
> >       sed -rn 's/.*\{.*"(.*)",.*,.*,.*},.*/\1/p'
> >app/test-pmd/parameters.c The misses were:
> >       --no-numa
> >       --enable-scatter
> >       --tx-ip
> >       --tx-udp
> >       --noisy-lkup-num-reads-writes
> >The option --ports was not implemented.
> >
> >Fixes: 01817b10d27c ("app/testpmd: change hairpin queues setup")
> >Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding
> >mode")
> >Fixes: bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP
> >parameters")
> >Fixes: 0499793854f5 ("app/testpmd: add scatter enabling option")
> >Fixes: 999b2ee0fe45 ("app/testpmd: enable NUMA support by default")
> >Fixes: af75078fece3 ("first public release")
> >Cc: stable at dpdk.org
> >
> >Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> >Acked-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
> >Acked-by: Bruce Richardson <bruce.richardson at intel.com>
> >Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
> >---
> > app/test-pmd/parameters.c | 35 ++++++++---------------------------
> > 1 file changed, 8 insertions(+), 27 deletions(-)
> >
> 
> Thank you Thomas!
> 
> Reviewed-by: Jens Freimann <jfreimann at redhat.com>
> 
> regards,
> Jens

Reviewed-by: Bing Zhao <bingz at nvidia.com>

Thanks a lot for the help.