[dpdk-dev] [PATCH v4 07/11] eal: add log level help

Thomas Monjalon thomas at monjalon.net
Tue Mar 23 16:10:19 CET 2021


23/03/2021 14:37, David Marchand:
> On Sun, Mar 21, 2021 at 11:32 PM Thomas Monjalon <thomas at monjalon.net> wrote:
> >
> > The option --log-level was not completely described in the usage text,
> > and it was difficult to guess the names of the log types and levels.
> >
> > A new value "help" is accepted after --log-level to give more details
> > about the syntax and listing the log types and levels.
> >
> > The array "levels" used for level name parsing is replaced with
> > a (modified) existing function which was used in rte_log_dump().
> 
> If we forget about the slightly different formatting, why not simply
> reuse rte_log_dump?
> It has the advantage of listing the default level for each logtype
> that a user cannot guess otherwise.

I considered rte_log_dump() too much verbose for the help text.
It is printing the global level and the logtype ids.
The need for the end-user in the help is different of a debug dump.





More information about the dev mailing list