[dpdk-dev] [PATCH] examples/pipeline: fix strtoul base
Dumitrescu, Cristian
cristian.dumitrescu at intel.com
Wed Mar 24 11:41:15 CET 2021
> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Wednesday, March 24, 2021 9:05 AM
> To: Khangar, Churchill <churchill.khangar at intel.com>
> Cc: dev at dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu at intel.com>; P,
> Venkata Suresh Kumar <venkata.suresh.kumar.p at intel.com>; Jangra,
> Yogesh <yogesh.jangra at intel.com>
> Subject: Re: [dpdk-dev] [PATCH] examples/pipeline: fix strtoul base
>
> 05/03/2021 16:15, Churchill Khangar:
> > This patch addresses the issue with strtoul base
>
> Which issue?
> Please explain what is broken and how it is fixed.
>
>
Nothing is broken here, this is incorrectly labeled as a fix. This is simply an small improvement to allow specification of integer arguments for the CLI commands in hexadecimal ( and octal :) ) as well as decimal, as opposed to just decimal.
Churchill, it would be great if you could update the title and description to reflect this as opposed to claiming a fix, and send v2, thanks!
Regards,
Cristian
More information about the dev
mailing list