[dpdk-dev] [PATCH v2] net/iavf: fix error logs

Alvin Zhang alvinx.zhang at intel.com
Tue May 11 04:11:16 CEST 2021


Remove some useless logs which are duplicated of the lower-level
function logs and may confuse users when running VF without some
features that not supported by PF.

Fixes: 5a038d19962d ("net/iavf: fix RSS configuration on i40e VF")
Fixes: 95f2f0e9fc2a ("net/iavf: improve default RSS")

Signed-off-by: Alvin Zhang <alvinx.zhang at intel.com>
---
 drivers/net/iavf/iavf_vchnl.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index ca5c56e..dfa7ce3 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -1519,11 +1519,8 @@
 	args.out_size = IAVF_AQ_BUF_SZ;
 
 	err = iavf_execute_vf_cmd(adapter, &args);
-	if (err) {
-		PMD_DRV_LOG(ERR,
-			    "Failed to execute command of OP_GET_RSS_HENA_CAPS");
+	if (err)
 		return err;
-	}
 
 	*caps = ((struct virtchnl_rss_hena *)args.out_buffer)->hena;
 	return 0;
@@ -1535,7 +1532,6 @@
 	struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);
 	struct virtchnl_rss_hena vrh;
 	struct iavf_cmd_info args;
-	int err;
 
 	vrh.hena = hena;
 	args.ops = VIRTCHNL_OP_SET_RSS_HENA;
@@ -1544,12 +1540,7 @@
 	args.out_buffer = vf->aq_resp;
 	args.out_size = IAVF_AQ_BUF_SZ;
 
-	err = iavf_execute_vf_cmd(adapter, &args);
-	if (err)
-		PMD_DRV_LOG(ERR,
-			    "Failed to execute command of OP_SET_RSS_HENA");
-
-	return err;
+	return iavf_execute_vf_cmd(adapter, &args);
 }
 
 int
-- 
1.8.3.1



More information about the dev mailing list