[dpdk-dev] [dpdk-stable] [PATCH] app/test: fix IPv6 header initialization

[David Marchand]

On Fri, Mar 26, 2021 at 5:37 PM Lance Richardson
<lance.richardson at broadcom.com> wrote:
>
> Fix two issues found when writing PMD unit tests for HW ptype and
> L4 checksum offload:

Would those unit tests be interesting to other pmd driver writers?


>
>    - The version field in the IPv6 header was being set to zero,
>      which prevented hardware from recognizing it as IPv6. The
>      IP version field is now set to six.
>    - The payload_len field was being initialized using host byte
>      order, which (among other things) resulted in incorrect L4
>      checksum computation. The payload_len field is now set using
>      network (big-endian) byte order.
>
> Fixes: 92073ef961ee ("bond: unit tests")

Odd that this never got caught before, I guess nobody ran the bonding
test with ipv6.

Adding new maintainers for the bonding code since this helper is only
used in the bonding ut.
Should we take this in 21.05 or wait 21.08?


> Cc: stable at dpdk.org
>
> Signed-off-by: Lance Richardson <lance.richardson at broadcom.com>

Reviewed-by: David Marchand <david.marchand at redhat.com>


-- 
David Marchand