[dpdk-dev] [PATCH] crypto/qat: fix NULL authentication request

[Iremonger, Bernard]

Hi Adam,

> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Zhang, Roy Fan
> Sent: Monday, May 10, 2021 12:42 PM
> To: Dybkowski, AdamX <adamx.dybkowski at intel.com>; dev at dpdk.org;
> Kusztal, ArkadiuszX <arkadiuszx.kusztal at intel.com>; gakhil at marvell.com
> Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix NULL authentication request
> 
> > -----Original Message-----
> > From: Dybkowski, AdamX <adamx.dybkowski at intel.com>
> > Sent: Monday, May 10, 2021 11:20 AM
> > To: dev at dpdk.org; Zhang, Roy Fan <roy.fan.zhang at intel.com>; Kusztal,
> > ArkadiuszX <arkadiuszx.kusztal at intel.com>; gakhil at marvell.com
> > Cc: Dybkowski, AdamX <adamx.dybkowski at intel.com>
> > Subject: [PATCH] crypto/qat: fix NULL authentication request
> >
> > This patch fixes the NULL auth generation case where the request
> > shouldn't contain the authentication result address. Allows to run
> > ipsec_autotest with a QAT device.
> >
> > Fixes: 65beb9abca6d ("crypto/qat: fix null auth when using VFIO")
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski at intel.com>
> > ---
> >  drivers/crypto/qat/qat_sym.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/crypto/qat/qat_sym.c
> > b/drivers/crypto/qat/qat_sym.c index a1f5676c04..9415ec7d32 100644
> > --- a/drivers/crypto/qat/qat_sym.c
> > +++ b/drivers/crypto/qat/qat_sym.c
> > @@ -399,8 +399,10 @@ qat_sym_build_request(void *in_op, uint8_t
> > *out_msg,
> >  		}
> >  		min_ofs = auth_ofs;
> >
> > -		auth_param->auth_res_addr =
> > -			op->sym->auth.digest.phys_addr;
> > +		if (ctx->qat_hash_alg != ICP_QAT_HW_AUTH_ALGO_NULL
> ||
> > +				ctx->auth_op ==
> > ICP_QAT_HW_AUTH_VERIFY)
> > +			auth_param->auth_res_addr =
> > +					op->sym->auth.digest.phys_addr;
> >
> >  	}
> >
> > --
> > 2.25.1
> 
> Acked-by: Fan Zhang <roy.fan.zhang at intel.com>

This patch should be backported, the following line should be added after the Fixes line:
Cc: stable at dpdk.org

Regards,

Bernard.