[dpdk-dev] [dpdk-stable] [PATCH v1 2/4] test/power: add turbo mode to freq check function

Thomas Monjalon thomas at monjalon.net
Wed May 12 17:34:59 CEST 2021


22/04/2021 18:13, Burakov, Anatoly:
> On 22-Apr-21 3:40 PM, David Hunt wrote:
> > --- a/app/test/test_power_cpufreq.c
> > +++ b/app/test/test_power_cpufreq.c
> > @@ -48,7 +48,7 @@ static uint32_t total_freq_num;
> >   static uint32_t freqs[TEST_POWER_FREQS_NUM_MAX];
> >   
> >   static int
> > -check_cur_freq(unsigned lcore_id, uint32_t idx)
> > +check_cur_freq(unsigned int lcore_id, uint32_t idx, int turbo)
> 
> Nitpicking, but stdbool exists :) it would be nice to use bool type for 
> bool variables, not int.

Dave, I think you missed this comment.






More information about the dev mailing list