[dpdk-dev] [PATCH v2 2/2] buildtools: check symbol maps in developer mode

[David Marchand]

On Wed, May 12, 2021 at 10:38 PM Thomas Monjalon <thomas at monjalon.net> wrote:
>
> 12/05/2021 22:24, Thomas Monjalon:
> > > > Hook check-symbol-maps.sh in the symbol check when in developer mode to
> > > > help developers catch issues before submitting their changes.
> > > >
> > > > Signed-off-by: David Marchand <david.marchand at redhat.com>
> > > +1
> > >
> > > Reviewed-by: Ray Kinsella <mdr at ashroe.eu>
> >
> > Series applied, thanks
>
> Oops, sorry no it cannot be merged as-is because of an incompatibility
> with Busybox grep: unrecognized option: exclude=version.map
>
> I think it is because of the old function find_orphan_symbols()
> using the option --exclude.

This could be fixed with:
-            if ! grep -q -r --exclude=$(basename $map) \
-                    -w $symsrc $(dirname $map) ; then
+            if [ -z "$(grep -rlw $symsrc $(dirname $map) |grep -v
$map)" ] ; then

Do you want a v3 with this change?


-- 
David Marchand