[dpdk-dev] [PATCH] devtools: warn about release notes updates

Thomas Monjalon thomas at monjalon.net
Thu May 20 12:18:33 CEST 2021


20/05/2021 11:59, David Marchand:
> On Thu, May 20, 2021 at 11:47 AM Thomas Monjalon <thomas at monjalon.net> wrote:
> > 20/05/2021 09:58, David Marchand:
> > > +     current_rn=${rel_notes_prefix}${major_version}_${minor_version}.rst
> > > +
> > > +     ! grep -e '^--- a/'$rel_notes_prefix -e '^+++ b/'$rel_notes_prefix $1 |
> >
> > Only the +++ part should matters.
> 
> It won't catch accidental removals.

Ah yes

> Besides, something that is not handled with my patch is renames.

I think we don't care about renames.

> But if we think those cases would be caught by reviewers, I can
> simplify this part in v2.

Catching any change (including removal) in old release notes look fine.




More information about the dev mailing list