[dpdk-dev] [PATCH] net/iavf: fix error handle for unsupported promisc configure

Xing, Beilei beilei.xing at intel.com
Thu May 27 03:54:29 CEST 2021



> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang at intel.com>
> Sent: Wednesday, May 26, 2021 5:53 PM
> To: Xing, Beilei <beilei.xing at intel.com>
> Cc: dev at dpdk.org; Zhang, Qi Z <qi.z.zhang at intel.com>; stable at dpdk.org
> Subject: [PATCH] net/iavf: fix error handle for unsupported promisc configure
> 
> iavf_execute_vf_cmd returns standard error code but not IAVF_xxx, The patch
> fix the wrong error handling in iavf_config_promisc.
> 
> Fixes: 1e4d55a7fe71 ("net/iavf: optimize promiscuous device operations")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Qi Zhang <qi.z.zhang at intel.com>
> ---
>  drivers/net/iavf/iavf_vchnl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index
> 5d57e8b541..02e828f9b7 100644
> --- a/drivers/net/iavf/iavf_vchnl.c
> +++ b/drivers/net/iavf/iavf_vchnl.c
> @@ -1257,8 +1257,8 @@ iavf_config_promisc(struct iavf_adapter *adapter,
>  		PMD_DRV_LOG(ERR,
>  			    "fail to execute command
> CONFIG_PROMISCUOUS_MODE");
> 
> -		if (err == IAVF_NOT_SUPPORTED)
> -			return -ENOTSUP;
> +		if (err == -ENOTSUP)
> +			return err;
> 
>  		return -EAGAIN;
>  	}
> --
> 2.26.2

Acked-by: Beilei Xing <beilei.xing at intel.com>



More information about the dev mailing list