[dpdk-dev] [PATCH v3 01/10] vdpa/sfc: introduce Xilinx vDPA driver

[Andrew Rybchenko]

Hi Chenbo,

Thanks for review.
Few questions from me below on your review notes.

Andrew.

On 11/1/21 11:30 AM, Xia, Chenbo wrote:
> Hi Vijay,
> 
>> -----Original Message-----
>> From: Vijay Srivastava <vijay.srivastava at xilinx.com>
>> Sent: Friday, October 29, 2021 10:47 PM
>> To: dev at dpdk.org
>> Cc: maxime.coquelin at redhat.com; Xia, Chenbo <chenbo.xia at intel.com>;
>> andrew.rybchenko at oktetlabs.ru; Vijay Kumar Srivastava <vsrivast at xilinx.com>
>> Subject: [PATCH v3 01/10] vdpa/sfc: introduce Xilinx vDPA driver
>>
>> From: Vijay Kumar Srivastava <vsrivast at xilinx.com>
>>
>> Add new vDPA PMD to support vDPA operations of Xilinx devices.
>> This patch implements probe and remove functions.
>>
>> Signed-off-by: Vijay Kumar Srivastava <vsrivast at xilinx.com>
>> Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
> 
> Note that your patch is not rebased on the latest commit. Reviewers
> may have trouble to review your patch.
>

[snip]

>> +	sva->vfio_group_fd =
>> +		rte_vfio_container_group_bind(sva->vfio_container_fd,
> 
> DPDK allows up to 100 chars per line. Please check all code that do not
> need new lines. It will make the code look better.

I'm sorry, but as far as I know permissive to have up to 100 chars
does not enforce to stretch all lines. Or am I missing something in
coding style? IMHO, it is still *allowed* to avoid lines longer than
80 chars.

[snip]