[dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion of ETH item with EtherType

[Raslan Darawsheh]

Hi,

> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Lior Margalit
> Sent: Monday, November 1, 2021 8:39 AM
> To: Matan Azrad <matan at nvidia.com>
> Cc: Lior Margalit <lmargalit at nvidia.com>; dev at dpdk.org; stable at dpdk.org
> Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS expansion of ETH item with
> EtherType
> 
> The RSS expansion algorithm is using a graph to find the possible
> expansion paths. A graph node with the 'explicit' flag will be skipped,
> if it is not found in the flow pattern.
> The current implementation misses a check for the explicit flag when
> expanding the pattern according to ETH item with EtherType.
> For example:
> testpmd> flow create 0 ingress pattern eth / ipv6 / udp / vxlan / eth type
> is 2048 / end actions rss level 2 types udp end / end
> The "eth type is 2048" item in the pattern may be expanded to "ETH IPv4".
> The ETH node in the expansion graph is followed by VLAN node marked as
> explicit. The fix is to skip the VLAN node and continue the expansion
> with its next nodes, IPv4 and IPv6.
> The expansion paths for the above example will be:
> ETH IPV6 UDP VXLAN ETH END
> ETH IPV6 UDP VXLAN ETH IPV4 UDP END
> 
> Fixes: 69d268b4fff3 ("net/mlx5: fix RSS expansion for explicit graph node")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Lior Margalit <lmargalit at nvidia.com>
> Acked-by: Matan Azrad <matan at nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh