[dpdk-dev] [PATCH] ethdev: fix variable length flow elements support

Gregory Etelson getelson at nvidia.com
Thu Nov 4 10:20:43 CET 2021


Hello Ferruh,

..snip..
> >
> > Negative type values assigned to PMD private
> items and actions.
> > RTE allows private PMD types in flow rules
> since
> > 5d1bff8fe2 ethdev: allow negative values in
> flow rule types
> > We construct flow rules with private PMD
> types
> > to implement tunnel offload.
> > However, negative type must not be used as
> index in
> > rte_flow_desc_item[] and
> rte_flow_desc_action[] arrays.
> >
> 
> That is what I assumed, but wasn't clear from
> commit log, commit log
> reads as it is updating an intended usage.
> 

I'll update the commit message in v2.

> >>> +     if (rte_type && desc[type].desc_fn)
> >>>                sz += desc[type].desc_fn(size > 0 ?
> buf
> >> : NULL, data);
> >>>        return sz;
> >>>    }
> >>>
> >

Regards,
Gregory



More information about the dev mailing list