[dpdk-dev] [PATCH] app/testpmd: fix flex item flush

Ferruh Yigit ferruh.yigit at intel.com
Fri Nov 5 19:56:24 CET 2021


On 11/5/2021 5:03 PM, Slava Ovsiienko wrote:
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit at intel.com>
>> Sent: Friday, November 5, 2021 17:57
>> To: Gregory Etelson <getelson at nvidia.com>; Slava Ovsiienko
>> <viacheslavo at nvidia.com>; Ori Kam <orika at nvidia.com>
>> Cc: Matan Azrad <matan at nvidia.com>; Raslan Darawsheh
>> <rasland at nvidia.com>; Xiaoyun Li <xiaoyun.li at intel.com>; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flex item flush
>>
>> On 10/26/2021 4:20 PM, Gregory Etelson wrote:
>>> Testpmd provides 2 sets of flex item create and destroy functions One
>>> for hosts with JSON library. These functions parse flex item
>>> configuration stored in JSON file and create or destroy flex item
>>> object. The second functions set is for hosts without JSON library for
>>> compilation compatibility.
>>>
>>> On hosts without JSON library, current implementation issues "no JSON
>>> library" notification on port close.
>>> The notification was triggered by port destructors that include flex
>>> items flush routine.
>>>
>>> The patch introduces single implementation for testpmd flex item
>>> destroy.
>>>
>>> Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands")
>>> Signed-off-by: Gregory Etelson<getelson at nvidia.com>
>>
>> Hi Viacheslav, Ori,
>>
>> Can you please help on reviewing this patch?
> Reviewed-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
> 
> I've already reviewed this one internally, so just posting the confirmation.
> As for maintainership of cmd_flex_item.c  - we talked with Ori,  he don't
> mind if I would take the responsibility for this. What should we do for that? Send patch
> to update MAINTAINERS ?
> 

Great, thanks.
Yes a maintainers file update is required.


More information about the dev mailing list