[dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

[David Marchand]

On Tue, Nov 9, 2021 at 10:03 AM Huichao Cai <chcchc88 at 163.com> wrote:
> >It could (should?) have been a single patch.
> --Yes, it can.I think the test unit is missing the offsets test content, so add this patch, and can also test the previous patch.

Too late, Thomas merged the fix in the library already.
Please consider this for future contributions.


> >A link to patchwork would avoid me wasting time looking for it.
>
> >I guess this is the patch Thomas merged last night.
> --I can see a link in my sent message，As in the screenshot below：
> --But I'm not sure why you didn't get the link when you got the email, I'm sorry.

I filter html.
I just saw your other reply: yes prefer plain text.

>
> >On the patch itself, the title is vague.
> >It should summarize what the change adds to the unit tests.
>
> >test/ipfrag: check fragment offsets
> --Thank you for reminding me, do I need to send another patch to modify the title?

You seem ok with this title, I'll go with it.

-- 
David Marchand