[PATCH v2] net/mlx5: fix missing RSS validation with meter policy
Raslan Darawsheh
rasland at nvidia.com
Tue Nov 16 10:25:02 CET 2021
Hi,
> -----Original Message-----
> From: Bing Zhao <bingz at nvidia.com>
> Sent: Monday, November 15, 2021 4:51 PM
> To: Slava Ovsiienko <viacheslavo at nvidia.com>; Matan Azrad
> <matan at nvidia.com>
> Cc: dev at dpdk.org; Raslan Darawsheh <rasland at nvidia.com>; Li Zhang
> <lizh at nvidia.com>; stable at dpdk.org
> Subject: [PATCH v2] net/mlx5: fix missing RSS validation with meter policy
>
> The RSS can be one of the fate actions when creating a meter with policy. In
> the previous implementation, the RSS validation was missed when creating a
> flow rule with such meter due to the fact that a policy meter was created
> firstly and then used in the rule. In the stage of meter creation, no
> rte_flow_item* information was provided.
>
> A unnecessary RSS expansion might be called since the validation was missed
> and would cause an unexpected error of the rule creation. Even though the
> rule should be rejected from the very beginning, it would cause confusion.
> There might be some other errors when the validation was missed.
>
> Adding the RSS validation inside the meter action validation will prevent the
> code from continuing when there is a conflict between the items, other
> actions and the policy meter RSS action.
>
> Fixes: 444320186393 ("net/mlx5: support meter creation with policy")
> Cc: lizh at nvidia.com
> Cc: stable at dpdk.org
>
> Signed-off-by: Bing Zhao <bingz at nvidia.com>
> Reviewed-by: Li Zhang <lizh at nvidia.com>
> Acked-by: Matan Azrad <matan at nvidia.com>
> ---
> v2: fix the coding style issue.
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
More information about the dev
mailing list