[PATCH] net: add macro for VLAN header length

Thomas Monjalon thomas at monjalon.net
Wed Nov 17 00:14:10 CET 2021


10/11/2021 18:40, Ferruh Yigit:
> Multiple drivers are defining macros for VLAN header length, to remove
> the redundancy defining macro in the ether header.
> And updated drivers to use the new macro.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
[...]
> --- a/lib/net/rte_ether.h
> +++ b/lib/net/rte_ether.h
> +#define RTE_VLAN_HLEN       4

Please could you add a doxygen comment for this constant?

> +/** Maximum VLAN frame length, including CRC. */
>  #define RTE_ETHER_MAX_VLAN_FRAME_LEN \
> -	(RTE_ETHER_MAX_LEN + 4)
> -	/**< Maximum VLAN frame length, including CRC. */
> +	(RTE_ETHER_MAX_LEN + RTE_VLAN_HLEN)

What about QinQ?




More information about the dev mailing list