[PATCH] net: add macro for VLAN header length

[Ferruh Yigit]

On 11/17/2021 10:02 AM, Thomas Monjalon wrote:
> 17/11/2021 11:00, Ferruh Yigit:
>> On 11/16/2021 11:14 PM, Thomas Monjalon wrote:
>>> 10/11/2021 18:40, Ferruh Yigit:
>>>> Multiple drivers are defining macros for VLAN header length, to remove
>>>> the redundancy defining macro in the ether header.
>>>> And updated drivers to use the new macro.
>>>>
>>>> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
>>> [...]
>>>> --- a/lib/net/rte_ether.h
>>>> +++ b/lib/net/rte_ether.h
>>>> +#define RTE_VLAN_HLEN       4
>>>
>>> Please could you add a doxygen comment for this constant?
>>>
>>
>> ack.
>>
>>>> +/** Maximum VLAN frame length, including CRC. */
>>>>    #define RTE_ETHER_MAX_VLAN_FRAME_LEN \
>>>> -	(RTE_ETHER_MAX_LEN + 4)
>>>> -	/**< Maximum VLAN frame length, including CRC. */
>>>> +	(RTE_ETHER_MAX_LEN + RTE_VLAN_HLEN)
>>>
>>> What about QinQ?
>>>
>>
>> I am just replacing hardcoded value with macro in this patch.
>> Changing 'RTE_ETHER_MAX_LEN' may have unexpected affect, and
>> may not be good thing to the at this stage.
> 
> Sure
> But can we take this opportunity to note that this macro
> does not take QinQ into account?
> Just a comment update?
> 

Yep, a can put a brief note.

> Same for RTE_VLAN_HLEN, it is only one VLAN.
> 
>