[PATCH] kni: restrict bifurcated device support

[Stephen Hemminger]

On Tue, 23 Nov 2021 16:51:27 +0000
Ferruh Yigit <ferruh.yigit at intel.com> wrote:

> >>>
> >>> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
> >>> index 611719b5ee27..d47fc6133cbe 100644
> >>> --- a/kernel/linux/kni/kni_net.c
> >>> +++ b/kernel/linux/kni/kni_net.c
> >>> @@ -838,6 +838,14 @@ kni_net_init(struct net_device *dev)
> >>>    	dev->header_ops      = &kni_net_header_ops;
> >>>    	dev->ethtool_ops     = &kni_net_ethtool_ops;
> >>>    	dev->watchdog_timeo = WD_TIMEOUT;
> >>> +
> >>> +	/*
> >>> +	 * KNI is unsafe since it requires calling userspace to do
> >>> +	 * control operations. And the overall quality according to
> >>> +	 * kernel standards is the same as devices in staging.
> >>> +	 */
> >>> +	add_taint(TAINT_CRAP, LOCKDEP_STILL_OK);
> >>> +	netdev_warn(dev, "Adding kernel taint for KNI because it is not safe\n");  
> >>
> >> I am for discussing above separate from this patch, since this patch
> >> restores the behavior that exist since KNI module exists.  
> > 
> > Any user of KNI will already get tainted because KNI is out of tree driver.
> >   
> 
> I mean the note and explicit 'add_taint()' you mentioned above, can we separate
> it from this bug fix.

I changed my mind, the existing taint that happens from out of tree is enough.
Especially since KNI is now deprecated.