[PATCH] Spelling
Ferruh Yigit
ferruh.yigit at intel.com
Mon Nov 29 15:03:12 CET 2021
On 11/29/2021 1:59 PM, Bruce Richardson wrote:
> On Mon, Nov 29, 2021 at 12:49:56PM +0000, Ferruh Yigit wrote:
>> On 11/26/2021 7:58 PM, Josh Soref wrote:
>>> diff --git a/app/test-eventdev/test_order_common.c b/app/test-eventdev/test_order_common.c
>>> index ff7813f9..603e7c91 100644
>>> --- a/app/test-eventdev/test_order_common.c
>>> +++ b/app/test-eventdev/test_order_common.c
>>> @@ -253,7 +253,7 @@ void
>>> order_opt_dump(struct evt_options *opt)
>>> {
>>> evt_dump_producer_lcores(opt);
>>> - evt_dump("nb_wrker_lcores", "%d", evt_nr_active_lcores(opt->wlcores));
>>> + evt_dump("nb_worker_lcores", "%d", evt_nr_active_lcores(opt->wlcores));
>>
>> Hi Josh, Thanks for the patch.
>>
>> The typo fixes for comments and logs are more straightforward, but I have
>> mixed feeling about the variable / macro typo fixes, let's see what others
>> think.
>>
>> And I think we should get this patch either one of the first patch or last
>> patch to prevent conflict with other patches.
>
> +1 to being a first patch to start things off clean.
>
> For the macros, since there is quick a bit of content in the patch, could
> we have the patch split into a separate patch for macro changes to review
> separately, allowing the simple doc/printf spelling changes to go in
> immediately?
>
Also as far as I can see there are multiple build errors related to the
variable / macro renames, which was the concern.
More information about the dev
mailing list