[dpdk-dev] [PATCH v1 3/3] test/crypto: add ZUC test cases for 256 bit key

[Vidya Sagar Velumuri]

Hi Pablo,
________________________________
From: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
Sent: 01 October 2021 17:38
To: Vidya Sagar Velumuri <vvelumuri at marvell.com>; Ankur Dwivedi <adwivedi at marvell.com>; Anoob Joseph <anoobj at marvell.com>; Tejasree Kondoj <ktejasree at marvell.com>; Nithin Kumar Dabilpuram <ndabilpuram at marvell.com>; Kiran Kumar Kokkilagadda <kirankumark at marvell.com>; Sunil Kumar Kori <skori at marvell.com>; Satha Koteswara Rao Kottidi <skoteshwar at marvell.com>; Akhil Goyal <gakhil at marvell.com>; Doherty, Declan <declan.doherty at intel.com>
Cc: dev at dpdk.org <dev at dpdk.org>
Subject: [EXT] RE: [dpdk-dev] [PATCH v1 3/3] test/crypto: add ZUC test cases for 256 bit key

External Email

----------------------------------------------------------------------
Hi Vidya,

> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Vidya Sagar Velumuri
> Sent: Wednesday, September 15, 2021 7:11 AM
> To: adwivedi at marvell.com; anoobj at marvell.com; ktejasree at marvell.com;
> ndabilpuram at marvell.com; kirankumark at marvell.com; skori at marvell.com;
> skoteshwar at marvell.com; gakhil at marvell.com; Doherty, Declan
> <declan.doherty at intel.com>
> Cc: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v1 3/3] test/crypto: add ZUC test cases for 256 bit
> key
>
> Add test cases for zuc 256 bit key.
> Add test case for zuc 8 and 16 byte digest with 256 bit key mode
>
> Signed-off-by: Vidya Sagar Velumuri <vvelumuri at marvell.com>

I see you added some test vectors for ZUC-256 and they all contain 24 bytes of IV.
>From the specs, I see that the IV is actually comprised of 23 full bytes or 25 bytes (where the first 17 are full and the last 8 contain 6 least significant bits each).
Could you tell me where those 24 bytes are coming from? I think there could be a conflict here with other implementations.
[sagar]:  yes, the IV should be 25 bytes. Will update the vectors with IV as per spec and push a new patch.

Thanks,
Pablo