[dpdk-dev] [PATCH v12 0/7] iavf: add iAVF IPsec inline crypto support

[Ferruh Yigit]

On 10/26/2021 2:56 PM, Radu Nicolau wrote:
> Add support for inline crypto for IPsec, for ESP transport and
> tunnel over IPv4 and IPv6, as well as supporting the offload for
> ESP over UDP, and inconjunction with TSO for UDP and TCP flows.
> 
> Radu Nicolau (7):
>    common/iavf: add iAVF IPsec inline crypto support
>    net/iavf: rework tx path
>    net/iavf: add support for asynchronous virt channel messages
>    net/iavf: add iAVF IPsec inline crypto support
>    net/iavf: add xstats support for inline IPsec crypto
>    net/iavf: add watchdog for VFLR
>    net/iavf: update doc with inline crypto support
> 

Hi Radu,

'./devtools/checkpatches.sh' complains about 'rte_atomicNN_xxx' usage:

Warning in drivers/net/iavf/iavf.h:
Using rte_atomicNN_xxx


We prefer C11 atomic builtins in new code, '__atomic_*',
can you please update to them.

There is some documentation around it, although it doesn't have much detail:
https://doc.dpdk.org/guides/prog_guide/writing_efficient_code.html#locks-and-atomic-operations


And since you will send a new version, there are a few warnings on
'./devtools/checkpatches.sh' & './devtools/check-git-log.sh', can you please
check them too?

Thanks,
ferruh