[dpdk-kmods] windows/netuio: fix bar parsing
Pallavi Kadam
pallavi.kadam at intel.com
Tue Aug 2 21:10:58 CEST 2022
For certain PCIe devices, BAR values are not continuous.
This patch maps all the BARs and avoids skipping the next BAR addresses.
Fixes: e28aabd88279 ("windows/netuio: introduce NetUIO kernel driver")
Cc: navasile at microsoft.com
Signed-off-by: Qiao Liu <qiao.liu at intel.com>
Signed-off-by: Pallavi Kadam <pallavi.kadam at intel.com>
---
windows/netuio/netuio_dev.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/windows/netuio/netuio_dev.c b/windows/netuio/netuio_dev.c
index b2deb10..e2cac3e 100644
--- a/windows/netuio/netuio_dev.c
+++ b/windows/netuio/netuio_dev.c
@@ -172,6 +172,7 @@ netuio_map_hw_resources(WDFDEVICE Device, WDFCMRESLIST Resources, WDFCMRESLIST R
ULONG next_descriptor = 0;
ULONG curr_bar = 0;
ULONG prev_bar = 0;
+ BOOLEAN bar_done = FALSE;
/*
* ResourcesTranslated report MMIO BARs in the correct order, but their
@@ -197,7 +198,8 @@ netuio_map_hw_resources(WDFDEVICE Device, WDFCMRESLIST Resources, WDFCMRESLIST R
for (INT bar_index = 0; bar_index < PCI_MAX_BAR; bar_index++) {
prev_bar = curr_bar;
curr_bar = pci_config.u.type0.BaseAddresses[bar_index];
- if (curr_bar == 0 || (prev_bar & PCI_TYPE_64BIT)) {
+ if (curr_bar == 0 || ((prev_bar & PCI_TYPE_64BIT) && (bar_done))) {
+ bar_done = FALSE;
continue;
}
@@ -219,6 +221,7 @@ netuio_map_hw_resources(WDFDEVICE Device, WDFCMRESLIST Resources, WDFCMRESLIST R
ctx->bar[bar_index].virt_addr = MmMapIoSpace(descriptor->u.Memory.Start,
descriptor->u.Memory.Length,
MmNonCached);
+ bar_done = TRUE;
if (ctx->bar[bar_index].virt_addr == NULL) {
status = STATUS_INSUFFICIENT_RESOURCES;
goto end;
--
2.31.1.windows.1
More information about the dev
mailing list