[PATCH v4 2/7] bbdev: add device status info
Maxime Coquelin
maxime.coquelin at redhat.com
Thu Aug 25 16:08:44 CEST 2022
On 7/6/22 23:16, Chautru, Nicolas wrote:
>>> +};
>>> +
>>> /** Device statistics. */
>>> struct rte_bbdev_stats {
>>> uint64_t enqueued_count; /**< Count of all operations enqueued */
>>> @@ -285,12 +300,14 @@ struct rte_bbdev_driver_info {
>>> /** Set if device supports per-queue interrupts */
>>> bool queue_intr_supported;
>>> /** Minimum alignment of buffers, in bytes */
>>> - uint16_t min_alignment;
>>> - /** HARQ memory available in kB */
>>> + /** Device Status */
>>> + enum rte_bbdev_device_status device_status;
>> New elements should be added to the end to improve backward compatibility.
> Same comment in different patch. I would like to know if there is a real recommendation from DPDK on this. I have heard opposite view as well.
> In that very case we are breaking the ABI in that new serie for 22.11 (sizes and offsets are changing).
>
Since we are breaking ABI anyways, I don't find it unreasonable to take
the opportunity to improve packing the struct.
Maxime
More information about the dev
mailing list