[PATCH v3 1/2] net/memif: add a Rx fast path
    Stephen Hemminger 
    stephen at networkplumber.org
       
    Wed Aug 31 18:25:50 CEST 2022
    
    
  
On Mon, 22 Aug 2022 03:47:30 +0000
Joyce Kong <joyce.kong at arm.com> wrote:
> +	if (likely(mbuf_size >= pmd->cfg.pkt_buffer_size)) {
> +		struct rte_mbuf *mbufs[nb_pkts];
> +		ret = rte_pktmbuf_alloc_bulk(mq->mempool, mbufs, nb_pkts);
> +			if (unlikely(ret < 0))
> +				goto no_free_bufs;
> +
The indentation looks off here, is this because of diff?
Also, my preference is to use blank line after declaration.
One more thing, the use of variable length array on stack will cause
the function to get additional overhead if stack-protector strong is
enabled.
    
    
More information about the dev
mailing list