[PATCH] bus: fix code unused

[taoyunxiang at cmss.chinamobile.com]

Hi David ,
      Thanks for your review, see the bellows.


--------------



taoyunxiang at cmss.chinamobile.com



>On Mon, May 16, 2022 at 9:38 AM taoyunxiang



><taoyunxiang at cmss.chinamobile.com> wrote:



>>



>> The return value of pci_plug in pci_common.c



>> will always be int vaule, can not be NULL.



>> We could use not 0 to check it.



>



>I don't see the relation between patch and commitlog.



>Please clarify what is the issue you want to fix.

I think we have some code unused, so fix it.


>



>



>>



>> Author: Tao YunXiang <taoyunxiang at cmss.chinamobile.com>



>> Signed-off-by: Tao YunXiang <taoyunxiang at cmss.chinamobile.com>



>>



>> ---



>>  lib/eal/common/eal_common_dev.c | 2 +-



>>  1 file changed, 1 insertion(+), 1 deletion(-)



>>



>> diff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c



>> index 148a23830a..99677bae58 100644



>> --- a/lib/eal/common/eal_common_dev.c



>> +++ b/lib/eal/common/eal_common_dev.c



>> @@ -143,7 +143,7 @@ local_dev_probe(const char *devargs, struct rte_device **new_dev)



>>         if (ret)



>>                 goto err_devarg;



>>



>> -       if (da->bus->plug == NULL) {



>> +       if (da->bus->plug != 0) {



>



>The current (before patch) check is correct: it is allowed that a bus



>does not support hotplug.



>Inverting this check as you propose breaks hotplug.


"da->bus->plug" will call pci_plug and  pci_probe_all_drivers in pci_common.c , is it right ?

The pci_probe_all_drivers will never return NULL,  so the check and related code will not go throuth,
no matter the plug is ok or not.


>



>



>>                 RTE_LOG(ERR, EAL, "Function plug not supported by bus (%s)\n",



>>                         da->bus->name);



>>                 ret = -ENOTSUP;



>



>



>-- 



>David Marchand



>