[EXT] Re: [PATCH] examples/l2fwd: add check of Rx packets count

[Rahul Bhansali]

Ping.

> -----Original Message-----
> From: Rahul Bhansali
> Sent: Wednesday, September 14, 2022 4:04 PM
> To: 'Thomas Monjalon' <thomas at monjalon.net>; 'dev at dpdk.org'
> <dev at dpdk.org>
> Cc: 'Bruce Richardson' <bruce.richardson at intel.com>; 'ferruh.yigit at xilinx.com'
> <ferruh.yigit at xilinx.com>; 'ajit.khaparde at broadcom.com'
> <ajit.khaparde at broadcom.com>; 'aboyer at pensando.io'
> <aboyer at pensando.io>; 'andrew.rybchenko at oktetlabs.ru'
> <andrew.rybchenko at oktetlabs.ru>; 'beilei.xing at intel.com'
> <beilei.xing at intel.com>; 'chas3 at att.com' <chas3 at att.com>;
> 'chenbo.xia at intel.com' <chenbo.xia at intel.com>; 'ciara.loftus at intel.com'
> <ciara.loftus at intel.com>; Devendra Singh Rawat <dsinghrawat at marvell.com>;
> 'ed.czeck at atomicrules.com' <ed.czeck at atomicrules.com>;
> 'evgenys at amazon.com' <evgenys at amazon.com>; 'grive at u256.net'
> <grive at u256.net>; 'g.singh at nxp.com' <g.singh at nxp.com>;
> 'zhouguoyang at huawei.com' <zhouguoyang at huawei.com>;
> 'haiyue.wang at intel.com' <haiyue.wang at intel.com>; Harman Kalra
> <hkalra at marvell.com>; 'heinrich.kuhn at corigine.com'
> <heinrich.kuhn at corigine.com>; 'hemant.agrawal at nxp.com'
> <hemant.agrawal at nxp.com>; 'hyonkim at cisco.com' <hyonkim at cisco.com>;
> 'igorch at amazon.com' <igorch at amazon.com>; Igor Russkikh
> <irusskikh at marvell.com>; 'jgrajcia at cisco.com' <jgrajcia at cisco.com>;
> 'jasvinder.singh at intel.com' <jasvinder.singh at intel.com>;
> 'jianwang at trustnetic.com' <jianwang at trustnetic.com>;
> 'jiawenwu at trustnetic.com' <jiawenwu at trustnetic.com>;
> 'jingjing.wu at intel.com' <jingjing.wu at intel.com>; 'johndale at cisco.com'
> <johndale at cisco.com>; 'john.miller at atomicrules.com'
> <john.miller at atomicrules.com>; 'linville at tuxdriver.com'
> <linville at tuxdriver.com>; 'keith.wiles at intel.com' <keith.wiles at intel.com>;
> Kiran Kumar Kokkilagadda <kirankumark at marvell.com>; 'oulijun at huawei.com'
> <oulijun at huawei.com>; Liron Himi <lironh at marvell.com>;
> 'longli at microsoft.com' <longli at microsoft.com>; 'mw at semihalf.com'
> <mw at semihalf.com>; 'spinler at cesnet.cz' <spinler at cesnet.cz>;
> 'matan at nvidia.com' <matan at nvidia.com>; 'matt.peters at windriver.com'
> <matt.peters at windriver.com>; 'maxime.coquelin at redhat.com'
> <maxime.coquelin at redhat.com>; 'mk at semihalf.com' <mk at semihalf.com>;
> 'humin29 at huawei.com' <humin29 at huawei.com>; Pradeep Kumar Nalla
> <pnalla at marvell.com>; Nithin Kumar Dabilpuram <ndabilpuram at marvell.com>;
> 'qiming.yang at intel.com' <qiming.yang at intel.com>; 'qi.z.zhang at intel.com'
> <qi.z.zhang at intel.com>; Radha Chintakuntla <radhac at marvell.com>;
> 'rahul.lakkireddy at chelsio.com' <rahul.lakkireddy at chelsio.com>; Rasesh Mody
> <rmody at marvell.com>; 'rosen.xu at intel.com' <rosen.xu at intel.com>;
> 'sachin.saxena at oss.nxp.com' <sachin.saxena at oss.nxp.com>; Satha Koteswara
> Rao Kottidi <skoteshwar at marvell.com>; 'Shahed Shaikh'
> <shshaikh at marvell.com>; 'shaibran at amazon.com' <shaibran at amazon.com>;
> 'shepard.siegel at atomicrules.com' <shepard.siegel at atomicrules.com>;
> 'asomalap at amd.com' <asomalap at amd.com>;
> 'somnath.kotur at broadcom.com' <somnath.kotur at broadcom.com>;
> 'sthemmin at microsoft.com' <sthemmin at microsoft.com>;
> 'steven.webster at windriver.com' <steven.webster at windriver.com>; Sunil
> Kumar Kori <skori at marvell.com>; 'mtetsuyah at gmail.com'
> <mtetsuyah at gmail.com>; Veerasenareddy Burru <vburru at marvell.com>;
> 'viacheslavo at nvidia.com' <viacheslavo at nvidia.com>; 'xiao.w.wang at intel.com'
> <xiao.w.wang at intel.com>; 'cloud.wangxiaoyun at huawei.com'
> <cloud.wangxiaoyun at huawei.com>; 'yisen.zhuang at huawei.com'
> <yisen.zhuang at huawei.com>; 'yongwang at vmware.com'
> <yongwang at vmware.com>; 'xuanziyang2 at huawei.com'
> <xuanziyang2 at huawei.com>
> Subject: RE: [EXT] Re: [PATCH] examples/l2fwd: add check of Rx packets count
> 
> Hi Thomas,
> 
> This got ack from Stephen Hemminger also. It is pending from long time, Can we
> consider this for RC1 ?
> 
> Regards,
> Rahul
> 
> > -----Original Message-----
> > From: Rahul Bhansali
> > Sent: Wednesday, July 20, 2022 10:22 PM
> > To: Thomas Monjalon <thomas at monjalon.net>; dev at dpdk.org
> > Cc: Bruce Richardson <bruce.richardson at intel.com>;
> > ferruh.yigit at xilinx.com; ajit.khaparde at broadcom.com;
> > aboyer at pensando.io; andrew.rybchenko at oktetlabs.ru;
> > beilei.xing at intel.com; chas3 at att.com; chenbo.xia at intel.com;
> > ciara.loftus at intel.com; Devendra Singh Rawat
> > <dsinghrawat at marvell.com>; ed.czeck at atomicrules.com;
> > evgenys at amazon.com; grive at u256.net; g.singh at nxp.com;
> > zhouguoyang at huawei.com; haiyue.wang at intel.com; Harman Kalra
> > <hkalra at marvell.com>; heinrich.kuhn at corigine.com;
> > hemant.agrawal at nxp.com; hyonkim at cisco.com; igorch at amazon.com; Igor
> > Russkikh <irusskikh at marvell.com>; jgrajcia at cisco.com;
> > jasvinder.singh at intel.com; jianwang at trustnetic.com;
> > jiawenwu at trustnetic.com; jingjing.wu at intel.com; johndale at cisco.com;
> > john.miller at atomicrules.com; linville at tuxdriver.com;
> > keith.wiles at intel.com; Kiran Kumar Kokkilagadda
> > <kirankumark at marvell.com>; oulijun at huawei.com; Liron Himi
> > <lironh at marvell.com>; longli at microsoft.com; mw at semihalf.com;
> > spinler at cesnet.cz; matan at nvidia.com; matt.peters at windriver.com;
> > maxime.coquelin at redhat.com; mk at semihalf.com; humin29 at huawei.com;
> > Pradeep Kumar Nalla <pnalla at marvell.com>; Nithin Kumar Dabilpuram
> > <ndabilpuram at marvell.com>; qiming.yang at intel.com;
> > qi.z.zhang at intel.com; Radha Chintakuntla <radhac at marvell.com>;
> > rahul.lakkireddy at chelsio.com; Rasesh Mody <rmody at marvell.com>;
> > rosen.xu at intel.com; sachin.saxena at oss.nxp.com; Satha Koteswara Rao
> > Kottidi <skoteshwar at marvell.com>; Shahed Shaikh
> > <shshaikh at marvell.com>; shaibran at amazon.com;
> > shepard.siegel at atomicrules.com; asomalap at amd.com;
> > somnath.kotur at broadcom.com; sthemmin at microsoft.com;
> > steven.webster at windriver.com; Sunil Kumar Kori <skori at marvell.com>;
> > mtetsuyah at gmail.com; Veerasenareddy Burru <vburru at marvell.com>;
> > viacheslavo at nvidia.com; xiao.w.wang at intel.com;
> > cloud.wangxiaoyun at huawei.com; yisen.zhuang at huawei.com;
> > yongwang at vmware.com; xuanziyang2 at huawei.com
> > Subject: RE: [EXT] Re: [PATCH] examples/l2fwd: add check of Rx packets
> > count
> >
> > Ping
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon <thomas at monjalon.net>
> > > Sent: Monday, June 27, 2022 2:42 AM
> > > To: dev at dpdk.org
> > > Cc: Bruce Richardson <bruce.richardson at intel.com>;
> > > ferruh.yigit at xilinx.com; ajit.khaparde at broadcom.com;
> > > aboyer at pensando.io; andrew.rybchenko at oktetlabs.ru;
> > > beilei.xing at intel.com; chas3 at att.com; chenbo.xia at intel.com;
> > > ciara.loftus at intel.com; Devendra Singh Rawat
> > > <dsinghrawat at marvell.com>; ed.czeck at atomicrules.com;
> > > evgenys at amazon.com; grive at u256.net; g.singh at nxp.com;
> > > zhouguoyang at huawei.com; haiyue.wang at intel.com; Harman Kalra
> > > <hkalra at marvell.com>; heinrich.kuhn at corigine.com;
> > > hemant.agrawal at nxp.com; hyonkim at cisco.com; igorch at amazon.com;
> Igor
> > > Russkikh <irusskikh at marvell.com>; jgrajcia at cisco.com;
> > > jasvinder.singh at intel.com; jianwang at trustnetic.com;
> > > jiawenwu at trustnetic.com; jingjing.wu at intel.com; johndale at cisco.com;
> > > john.miller at atomicrules.com; linville at tuxdriver.com;
> > > keith.wiles at intel.com; Kiran Kumar Kokkilagadda
> > > <kirankumark at marvell.com>; oulijun at huawei.com; Liron Himi
> > > <lironh at marvell.com>; longli at microsoft.com; mw at semihalf.com;
> > > spinler at cesnet.cz; matan at nvidia.com; matt.peters at windriver.com;
> > > maxime.coquelin at redhat.com; mk at semihalf.com; humin29 at huawei.com;
> > > Pradeep Kumar Nalla <pnalla at marvell.com>; Nithin Kumar Dabilpuram
> > > <ndabilpuram at marvell.com>; qiming.yang at intel.com;
> > > qi.z.zhang at intel.com; Radha Chintakuntla <radhac at marvell.com>;
> > > rahul.lakkireddy at chelsio.com; Rasesh Mody <rmody at marvell.com>;
> > > rosen.xu at intel.com; sachin.saxena at oss.nxp.com; Satha Koteswara Rao
> > > Kottidi <skoteshwar at marvell.com>; Shahed Shaikh
> > > <shshaikh at marvell.com>; shaibran at amazon.com;
> > > shepard.siegel at atomicrules.com; asomalap at amd.com;
> > > somnath.kotur at broadcom.com; sthemmin at microsoft.com;
> > > steven.webster at windriver.com; Sunil Kumar Kori <skori at marvell.com>;
> > > mtetsuyah at gmail.com; Veerasenareddy Burru <vburru at marvell.com>;
> > > viacheslavo at nvidia.com; xiao.w.wang at intel.com;
> > > cloud.wangxiaoyun at huawei.com; yisen.zhuang at huawei.com;
> > > yongwang at vmware.com; xuanziyang2 at huawei.com; Rahul Bhansali
> > > <rbhansali at marvell.com>
> > > Subject: [EXT] Re: [PATCH] examples/l2fwd: add check of Rx packets
> > > count
> > >
> > > External Email
> > >
> > > --------------------------------------------------------------------
> > > -- Please could we have some tests on other hardware with this
> > > improvement?
> > >
> > >
> > > 25/05/2022 11:13, Rahul Bhansali:
> > > > An additional check is added to avoid extra processing if receive
> > > > packets are 0.
> > > >
> > > > Performance impact: with Marvell OCTEON TX2 platform, observed an
> > > > improvement by ~14%.
> > > >
> > > > Signed-off-by: Rahul Bhansali <rbhansali at marvell.com>
> > > > ---
> > > >  			nb_rx = rte_eth_rx_burst(portid, 0,
> > > >  						 pkts_burst, MAX_PKT_BURST);
> > > >
> > > > +			if (unlikely(nb_rx == 0))
> > > > +				continue;
> > > > +
> > >
> > >
> > >