[PATCH v1 1/1] baseband/acc: fix to possible negative shift

Nicolas Chautru nicolas.chautru at intel.com
Wed Nov 2 19:30:50 CET 2022


Potential occurrence of negative shift when using invalid
configuration on ACC200. Enforcing that depth > 0.

Coverity issue: 381636
Fixes: 40e3adbdd3 ("baseband/acc200: add queue configuration")

Signed-off-by: Nicolas Chautru <nicolas.chautru at intel.com>
---
 drivers/baseband/acc/rte_acc200_pmd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/baseband/acc/rte_acc200_pmd.c b/drivers/baseband/acc/rte_acc200_pmd.c
index 8ee9023451..7d7a6c6389 100644
--- a/drivers/baseband/acc/rte_acc200_pmd.c
+++ b/drivers/baseband/acc/rte_acc200_pmd.c
@@ -105,9 +105,9 @@ aqDepth(int qg_idx, struct rte_acc_conf *acc_conf)
 	qtopFromAcc(&q_top, acc_enum, acc_conf);
 
 	if (unlikely(q_top == NULL))
-		return 0;
+		return 1;
 
-	return q_top->aq_depth_log2;
+	return RTE_MAX(1, q_top->aq_depth_log2);
 }
 
 /* Return the AQ depth for a Queue Group Index. */
-- 
2.37.1



More information about the dev mailing list