[PATCH] power: fix double free of opened files

Tadhg Kearney tadhg.kearney at intel.com
Fri Nov 4 17:23:53 CET 2022


Fix double free of f_min and f_max by reverting the flcose() for f_min
and f_max. As f_min and f_max are stored for further use and closed in
uncore deinitialization.

Fixes: b127e74 ("power: fix open file descriptors leak")

Signed-off-by: Tadhg Kearney <tadhg.kearney at intel.com>
---
 lib/power/rte_power_intel_uncore.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/power/rte_power_intel_uncore.c b/lib/power/rte_power_intel_uncore.c
index f86e1c8b7a..3b8724385f 100644
--- a/lib/power/rte_power_intel_uncore.c
+++ b/lib/power/rte_power_intel_uncore.c
@@ -194,8 +194,7 @@ power_init_for_setting_uncore_freq(struct uncore_power_info *ui)
 
 	fclose(f_base_min);
 	fclose(f_base_max);
-	fclose(f_max);
-	fclose(f_min);
+	/* f_min and f_max are stored, no need to close */
 
 	return 0;
 
-- 
2.25.1



More information about the dev mailing list