[PATCH 1/4] gve: remove unnecessary null checks

Stephen Hemminger stephen at networkplumber.org
Thu Nov 10 00:46:46 CET 2022


The function rte_free() already handles NULL argument;
therefore the checks in this code are unnecessary.

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 drivers/net/gve/gve_ethdev.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c
index 0086162f63b3..a05e61feba1f 100644
--- a/drivers/net/gve/gve_ethdev.c
+++ b/drivers/net/gve/gve_ethdev.c
@@ -81,12 +81,10 @@ gve_free_qpls(struct gve_priv *priv)
 	for (i = 0; i < nb_txqs + nb_rxqs; i++) {
 		if (priv->qpl[i].mz != NULL)
 			rte_memzone_free(priv->qpl[i].mz);
-		if (priv->qpl[i].page_buses != NULL)
-			rte_free(priv->qpl[i].page_buses);
+		rte_free(priv->qpl[i].page_buses);
 	}
 
-	if (priv->qpl != NULL)
-		rte_free(priv->qpl);
+	rte_free(priv->qpl);
 }
 
 static int
-- 
2.35.1



More information about the dev mailing list