[PATCH] net/failsafe: Fix crash due to in-valid sub-device port id
madhuker.mythri at oracle.com
madhuker.mythri at oracle.com
Wed Nov 16 10:52:24 CET 2022
From: Madhuker Mythri <madhuker.mythri at oracle.com>
Crash occuring while the DPDK secondary processes trying to probe the tap-device, where tap-device is a sub-device of Fail-safe device.
Some-times we get in-valid sub-devices(with the in-valid port-id’s and device-names), due to which the IPC communication does not get response and causes the communication failures b/w primary/secondary process.
So, need to validate the sub-device(tap) while secondary process probe in the Fail-safe PMD, to avoid such issues.
Bugzilla Id: 1116
Signed-off-by: Madhuker Mythri <madhuker.mythri at oracle.com>
---
drivers/net/failsafe/failsafe.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c
index 32811403b4..3663976697 100644
--- a/drivers/net/failsafe/failsafe.c
+++ b/drivers/net/failsafe/failsafe.c
@@ -361,6 +361,10 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev)
if (sdev->devargs.name[0] == '\0')
continue;
+ if (!rte_eth_dev_is_valid_port(PORT_ID(sdev))) {
+ continue;
+ }
+
/* rebuild devargs to be able to get the bus name. */
ret = rte_devargs_parse(&devargs,
sdev->devargs.name);
--
2.32.0.windows.1
More information about the dev
mailing list