[PATCH] app/testpmd: fix action destruction memory leak
Suanming Mou
suanmingm at nvidia.com
Thu Nov 17 09:55:37 CET 2022
In case action handle destroy fails, the job memory was not freed
properly. This commit fixes the possible memory leak in the action
handle destruction failed case.
Fixes: c9dc03840873 ("ethdev: add indirect action async query")
Signed-off-by: Suanming Mou <suanmingm at nvidia.com>
---
app/test-pmd/config.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 982549ffed..719bdd4261 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -2873,9 +2873,9 @@ port_queue_action_handle_destroy(portid_t port_id,
job->type = QUEUE_JOB_TYPE_ACTION_DESTROY;
job->pia = pia;
- if (pia->handle &&
- rte_flow_async_action_handle_destroy(port_id,
+ if (rte_flow_async_action_handle_destroy(port_id,
queue_id, &attr, pia->handle, job, &error)) {
+ free(job);
ret = port_flow_complain(&error);
continue;
}
--
2.25.1
More information about the dev
mailing list