[PATCH 3/3] net/txgbe: fix security session destroy

[Zhang, Qi Z]

> -----Original Message-----
> From: Jiawen Wu <jiawenwu at trustnetic.com>
> Sent: Friday, October 14, 2022 5:59 PM
> To: Nicolau, Radu <radu.nicolau at intel.com>; 'Jian Wang'
> <jianwang at trustnetic.com>
> Cc: dev at dpdk.org; gakhil at marvell.com
> Subject: RE: [PATCH 3/3] net/txgbe: fix security session destroy
> 
> On Thursday, October 13, 2022 8:19 PM, Radu Nicolau wrote:
> > Replace mempool_put with memset 0, the internal session memory block
> > is no longer allocated from a mempool
> >
> > Fixes: 3f3fc3308bd0 ("security: remove private mempool usage")
> > Cc: gakhil at marvell.com
> >
> > Signed-off-by: Radu Nicolau <radu.nicolau at intel.com>
> > ---
> >  drivers/net/txgbe/txgbe_ipsec.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/txgbe/txgbe_ipsec.c
> > b/drivers/net/txgbe/txgbe_ipsec.c index
> > b458b3a922..f9f8108fb8 100644
> > --- a/drivers/net/txgbe/txgbe_ipsec.c
> > +++ b/drivers/net/txgbe/txgbe_ipsec.c
> > @@ -409,7 +409,6 @@ txgbe_crypto_remove_session(void *device,  {
> >  	struct rte_eth_dev *eth_dev = device;
> >  	struct txgbe_crypto_session *ic_session =
> SECURITY_GET_SESS_PRIV(session);
> > -	struct rte_mempool *mempool =
> rte_mempool_from_obj(ic_session);
> >
> >  	if (eth_dev != ic_session->dev) {
> >  		PMD_DRV_LOG(ERR, "Session not bound to this device\n");
> @@ -421,7
> > +420,7 @@ txgbe_crypto_remove_session(void *device,
> >  		return -EFAULT;
> >  	}
> >
> > -	rte_mempool_put(mempool, (void *)ic_session);
> > +	memset(ic_session, 0, sizeof(struct txgbe_crypto_session));
> >
> >  	return 0;
> >  }
> > --
> > 2.25.1
> >
> >
> 
> Reviewed-by: Jiawen Wu <jiawenwu at trustnetic.com>

Applied to dpdk-next-net-intel.

Thanks
Qi