[PATCH v8 1/2] ethdev: add query_update sync and async function calls

Andrew Rybchenko andrew.rybchenko at oktetlabs.ru
Thu Feb 2 11:47:36 CET 2023


On 2/2/23 13:44, Gregory Etelson wrote:
> Hello Andrew,
> 
> []
> 
>> On 2/2/23 13:24, Gregory Etelson wrote:
>>>> On 2/1/23 18:16, Gregory Etelson wrote:
>>>>> +     ops = rte_flow_ops_get(port_id, error);
>>>>> +     if (!ops || !ops->action_handle_query_update)
>>>>> +             return -ENOTSUP;
>>>>
>>>> May be it makes sense to use single-operation callbacks if
>>>> another operation input is NULL. I guess it could be
>>>> convenient in some cases. Just an idea.
>>>>
>>>
>>> There is a plan to deprecate indirect query and update functions
>>> and replace them with a single query_update.
>>
>> So, will you add corresponding code? Just want to clarify.
>>
> 
> There is ongoing work on next stage of indirect action functions.
> The plan is to deprecate existing API when all updates will be introduced.

IMHO nothing prevents to add handling right now. It will allow
to use query_update instead of just query or update from the
very beginning. Not a strong requirement. Just nice to have
from my point of view.




More information about the dev mailing list