no printf in drivers code
Honnappa Nagarahalli
Honnappa.Nagarahalli at arm.com
Sat Feb 4 05:38:38 CET 2023
<snip>
> Subject: Re: no printf in drivers code
>
> On Fri, Feb 3, 2023 at 5:40 PM Thomas Monjalon <thomas at monjalon.net>
> wrote:
> >
> > 03/02/2023 17:18, Honnappa Nagarahalli:
> > > From: Thomas Monjalon <thomas at monjalon.net>
> > > >
> > > > We have too many drivers using printf() instead of rte_log().
> > > > Please propose a plan to replace or remove the calls to printf().
> > > > If no plan, I could propose one but you may not like it :)
> > >
> > > Does it make sense to add scripts to CI to capture this issue?
> > > In general, we do not want printfs in DPDK code (other than tests,
> > > sample apps?)
> >
> > It's difficult to automate because printfs are acceptable in dump
> > functions, selftest, and testpmd code hosted in drivers directories.
>
> We can identify which parts need those, create dedicated helpers that do call
> printf (but are excluded from the check), and and then the printf exclusion is
> applied to the whole tree.
+1
>
>
> --
> David Marchand
More information about the dev
mailing list