[PATCH] bus: fix leak for devices without driver

Kevin Laatz kevin.laatz at intel.com
Wed Feb 8 12:30:30 CET 2023


Hi Volodymyr,

On 07/01/2023 15:12, Volodymyr Fialko wrote:
> For devices not assigned to any driver, we leak a pci device object since
> it is never freed from the PCI bus device list, reported by ASAN.
>
> Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown")
>
> Signed-off-by: Volodymyr Fialko <vfialko at marvell.com>
> ---
>   drivers/bus/pci/pci_common.c | 3 ++-
>   drivers/bus/vdev/vdev.c      | 5 +++--
>   2 files changed, 5 insertions(+), 3 deletions(-)
>
This fix LGTM, but its tricky to reproduce so I have not been able to 
test this.

Could you add some more text to the commit message describing the issue 
and fix, please?

/Kevin



More information about the dev mailing list