[PATCH v7 2/4] event/dlb2: remove superfluous rte_memcpy

Sevincer, Abdullah abdullah.sevincer at intel.com
Thu Feb 9 19:50:06 CET 2023


Acked: by abdullah.sevincer at intel.com

-----Original Message-----
From: Morten Brørup <mb at smartsharesystems.com> 
Sent: Thursday, February 9, 2023 8:51 AM
To: dev at dpdk.org; roretzla at linux.microsoft.com; rmody at marvell.com; McDaniel, Timothy <timothy.mcdaniel at intel.com>; matan at nvidia.com; viacheslavo at nvidia.com
Cc: ruifeng.wang at arm.com; zhoumin at loongson.cn; drc at linux.vnet.ibm.com; kda at semihalf.com; Richardson, Bruce <bruce.richardson at intel.com>; konstantin.v.ananyev at yandex.ru
Subject: RE: [PATCH v7 2/4] event/dlb2: remove superfluous rte_memcpy

PING dlb2 maintainers. Care to review this, so it can be included in 23.03?

> From: Morten Brørup [mailto:mb at smartsharesystems.com]
> Sent: Monday, 16 January 2023 14.07
> 
> Copying with the same src and dst address has no effect; removed to 
> avoid compiler warning with decorated rte_memcpy.
> 
> Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init")
> Cc: timothy.mcdaniel at intel.com
> 
> Signed-off-by: Morten Brørup <mb at smartsharesystems.com>
> Acked-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
> v7:
> * No changes.
> v6:
> * Add Fixes to patch description. (Stephen)
> v5:
> * First patch in series.
> ---
>  drivers/event/dlb2/dlb2.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c 
> index 60c5cd4804..03d32c779f 100644
> --- a/drivers/event/dlb2/dlb2.c
> +++ b/drivers/event/dlb2/dlb2.c
> @@ -215,7 +215,6 @@ static int
>  dlb2_hw_query_resources(struct dlb2_eventdev *dlb2)  {
>  	struct dlb2_hw_dev *handle = &dlb2->qm_instance;
> -	struct dlb2_hw_resource_info *dlb2_info = &handle->info;
>  	int num_ldb_ports;
>  	int ret;
> 
> @@ -277,8 +276,6 @@ dlb2_hw_query_resources(struct dlb2_eventdev *dlb2)
>  	handle->info.hw_rsrc_max.reorder_window_size =
>  		dlb2->hw_rsrc_query_results.num_hist_list_entries;
> 
> -	rte_memcpy(dlb2_info, &handle->info.hw_rsrc_max,
> sizeof(*dlb2_info));
> -
>  	return 0;
>  }
> 
> --
> 2.17.1



More information about the dev mailing list