[PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

Ferruh Yigit ferruh.yigit at amd.com
Mon Feb 20 23:57:47 CET 2023


On 2/20/2023 9:11 PM, Levend Sayar wrote:
> rx no_mbufs stats counter update is added for another error case.
> 
> Fixes: 4f6b1dd8240c ("net/gve: support basic statistics")
> Cc: junfeng.guo at intel.com
> 
> Signed-off-by: Levend Sayar <levendsayar at gmail.com>
> ---
>  drivers/net/gve/gve_rx.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/gve/gve_rx.c b/drivers/net/gve/gve_rx.c
> index 66fbcf3930..d346efa57c 100644
> --- a/drivers/net/gve/gve_rx.c
> +++ b/drivers/net/gve/gve_rx.c
> @@ -61,7 +61,10 @@ gve_rx_refill(struct gve_rx_queue *rxq)
>  					break;
>  				rxq->sw_ring[idx + i] = nmb;
>  			}
> -			nb_alloc = i;
> +			if (i != nb_alloc) {
> +				rxq->no_mbufs += nb_alloc - i;
> +				nb_alloc = i;
> +			}
>  		}
>  		rxq->nb_avail -= nb_alloc;
>  		next_avail += nb_alloc;

Looks good to me,
there was a comment from Stephen to add 'unlikely()', is that issue
resolved?


More information about the dev mailing list