[PATCH] net/af_xdp: fix integer handling issues

Shibin Koikkara Reeny shibin.koikkara.reeny at intel.com
Tue Feb 21 12:14:26 CET 2023


Fix integer handling issues (NEGATIVE_RETURNS) reported
in coverity scan. Add a check to sock variable if the
value is negative return -1.

Coverity issue: 383245
Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration")

Signed-off-by: Shibin Koikkara Reeny <shibin.koikkara.reeny at intel.com>
---
 drivers/net/af_xdp/rte_eth_af_xdp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
index 02c874d51e..2a20a6960c 100644
--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
@@ -1508,6 +1508,8 @@ get_cni_fd(char *if_name)
 
 	memset(&server, 0, sizeof(server));
 	sock = init_uds_sock(&server);
+	if (sock < 0)
+		return -1;
 
 	/* Initiates handshake to CNI send: /connect,hostname */
 	snprintf(request, sizeof(request), "%s,%s", UDS_CONNECT_MSG, hostname);
-- 
2.25.1



More information about the dev mailing list