[PATCH v5] net/gve: add Rx/Tx queue stats as extended stats
Levend Sayar
levendsayar at gmail.com
Tue Feb 21 17:44:17 CET 2023
Thanks Ferruh for the review.
> On 21 Feb 2023, at 18:58, Ferruh Yigit <ferruh.yigit at amd.com> wrote:
>
> On 2/21/2023 2:18 PM, Levend Sayar wrote:
>> Google Virtual NIC rx/tx queue stats are added as extended stats.
>>
>> Signed-off-by: Levend Sayar <levendsayar at gmail.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit at amd.com>
>
> <...>
>
>> @@ -20,6 +20,7 @@ gve_rx_refill(struct gve_rx_queue *rxq)
>> if (nb_alloc <= rxq->nb_avail) {
>> diag = rte_pktmbuf_alloc_bulk(rxq->mpool, &rxq->sw_ring[idx], nb_alloc);
>> if (diag < 0) {
>> + rxq->stats.no_mbufs_bulk++;
>
> It is not common to record bulk alloc failures, but as 'no_mbufs'
> already recorded conventionally, I guess it is OK to keep this extra
> stat if it is helpful.
>
More information about the dev
mailing list