[PATCH v8 04/22] efd: replace RTE_LOGTYPE_EFD with dynamic type

[Stephen Hemminger]

On Tue, 21 Feb 2023 15:55:29 +0100
David Marchand <david.marchand at redhat.com> wrote:

> On Tue, Feb 21, 2023 at 12:36 AM Stephen Hemminger
> <stephen at networkplumber.org> wrote:
> >
> > Replace all uses of the global logtype with a dynamic log type.
> >
> > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> > ---
> >  lib/eal/common/eal_common_log.c | 1 -
> >  lib/eal/include/rte_log.h       | 2 +-
> >  lib/efd/rte_efd.c               | 4 ++++
> >  3 files changed, 5 insertions(+), 2 deletions(-)  
> 
> [snip]
> 
> > diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c
> > index 686a13775742..9edb11799c89 100644
> > --- a/lib/efd/rte_efd.c
> > +++ b/lib/efd/rte_efd.c
> > @@ -9,6 +9,7 @@
> >  #include <errno.h>
> >  #include <sys/queue.h>
> >
> > +#include <rte_cpuflags.h>
> >  #include <rte_string_fns.h>
> >  #include <rte_log.h>
> >  #include <rte_eal_memconfig.h>  
> 
> This is unrelated, isn't it?

Not really, the old code worked only because it would get rte_cpuflags.h
included via rte_hash_crc.h.  When rte_hash_crc.h was fixed to not
do per-cpu setup in inline, then the cpu flags did not need to be
included there.